Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Adding FR 04-16753 #9

Merged
merged 2 commits into from
May 30, 2017
Merged

Adding FR 04-16753 #9

merged 2 commits into from
May 30, 2017

Conversation

gregoryfoster
Copy link
Contributor

@gregoryfoster gregoryfoster commented May 24, 2017 •
edited
Loading

There are two amendments in FR 04-16753 which omit interim markers, causing regulations-parser to be unable to derive paragraph depths.

Reproduction of the error can be accomplished using regulations-parser:

eregs clear
eregs preprocess_notice 04-16753
eregs write_to output

The following changes were introduced to the source FR XML document:

  1. For 37 CFR 1 amendment 3, an asterisk node has been added for § 1.25 (c)(1).
  2. For 37 CFR 2 amendment 3, an asterisk node has been added for § 2.208 (c)(1).

These changes enable the parser to correctly identify the paragraph depths and process the amendments.

@cmc333333 cmc333333 mentioned this pull request May 30, 2017
Open
@cmc333333
Copy link
Member

Thanks @gregoryfoster! This sort of amendment should work automatically, so I've created eregs/regulations-parser#381 to track.

@cmc333333 cmc333333 merged commit f6d97cc into eregs:master May 30, 2017
@gregoryfoster gregoryfoster deleted the 04-16753 branch June 21, 2017 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregoryfoster @cmc333333